Skip to content

DDC's sdk JS needs to be included in the sdk #27001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmesserly opened this issue Aug 1, 2016 · 7 comments
Closed

DDC's sdk JS needs to be included in the sdk #27001

jmesserly opened this issue Aug 1, 2016 · 7 comments
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler

Comments

@jmesserly
Copy link

it looks like maybe we could do this in utils/dartdevc/dartdevc.gyp, but I don't know how to do anything in GYP

@jmesserly
Copy link
Author

@vsmenon any ideas here? we need to copy dart_library.js and dart_sdk.js so they're available and match the version of DDC in the DEPS file

@jmesserly
Copy link
Author

btw, thanks to @nex3 for finding this :)

@jmesserly jmesserly added P2 A bug or feature request we're likely to work on web-dev-compiler labels Aug 1, 2016
@vsmenon
Copy link
Member

vsmenon commented Oct 14, 2016

@jakemac53 @sigmundch

We should probably copy everything under lib/js.

@sigmundch
Copy link
Member

2 ideas: you can put the files directly somewhere under sdk/_internal/* like we do with js_runtime for dart2js, or you can use gyp/GN to copy the files. The gyp/GN rule would be similar to what the analyzer folks did to generate strong.sum under the sdk. For example, see

'action_name': 'generate_summary_strong',

@vsmenon
Copy link
Member

vsmenon commented Oct 14, 2016

@nex3
Copy link
Member

nex3 commented Oct 30, 2016

What's the intended process for users to find and use these sources?

@vsmenon
Copy link
Member

vsmenon commented Oct 31, 2016

See related in #27607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Development

No branches or pull requests

4 participants