Skip to content

Add --packages flag to test.py, to use a package spec file instead of a package root. #27063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whesse opened this issue Aug 12, 2016 · 1 comment
Closed

Add --packages flag to test.py, to use a package spec file instead of a package root. #27063

whesse opened this issue Aug 12, 2016 · 1 comment
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
1.19

Comments

@whesse
Copy link
Contributor

whesse commented Aug 12, 2016

This is needed to test packages that use the new pub --no-package-symlinks option, and therefore only have a .package file, not a packages/ directory.

Some of the bots on the package waterfall are currently failing because this option is missing.
@whesse whesse added P1 A high priority bug; for example, a single project is unusable or has many test failures area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Aug 12, 2016
@whesse whesse added this to the 1.19 milestone Aug 12, 2016
@whesse whesse self-assigned this Aug 12, 2016
@whesse whesse mentioned this issue Aug 12, 2016
Closed
3 tasks
whesse added a commit that referenced this issue Aug 12, 2016
@whesse
Add --packages flag to test.py, to specify a package spec file.
9b8f01f 
BUG=#27063

Review URL: https://codereview.chromium.org/2240193002 .
whesse added a commit to dart-archive/package-bots that referenced this issue Aug 15, 2016
@whesse
Update test scripts used by package bots to version 1.19.0-dev.6.0
b4bdabf 
The version of the Dart vm and dart2js tested are always the last dev
build, but the test.py scripts were pinned at 1.16.0. Pinning them
to 1.19.0-dev.6.0 to get new --package option.

BUG=dart-lang/sdk#27063
[email protected], [email protected]

Review URL: https://chromiumcodereview.appspot.com//2243233002 .
@whesse
Copy link
Contributor Author

whesse commented Aug 16, 2016

This is now working, at least for the cases used on the package waterfall.
Checking the dartium case will be done in a separate issue.

@whesse whesse closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
1.19
Development

No branches or pull requests
1 participant
@whesse