Code completing the value of a named argument doesn't show expected option: enum values

[sethladd]

Here's the code in question:

import 'package:flutter/material.dart';

void main() {
  runApp(new MyApp());
}

class MyApp extends StatelessComponent {
  Widget build(BuildContext context) {
    return new Column([
      new Center(child: new Text("first")),
      new Center(child: new Text("second")),
      new Center(child: new Text("third"))
    ], justifyContent: );
  }
}

Put your cusor after justifyContent: and try to code complete.

Expected: Show me FlexJustifyContent. That's what justifyContent is annotated for.

Actual: a bunch of options, none of which make sense in this context.

Hope that helps. Thanks!

[sethladd]

cc @devoncarew @danrubel

[sethladd]

FWIW, if I start typing the correct type name (Flex...) I get all options that start with Flex, instead of the one option that really only works here.

[jwren]

Work in progress. PR to be uploaded soon.

[jwren]

https://codereview.chromium.org/1881733002/- gets us closer to having only the correct kind of thing suggested in some named argument list.

There is no such justifyContext any more. @sethladd what kind of annotation do you want respected? Is it Flutter specific? I don't think we have any such support in code completion yet.

[jwren]

@devoncarew Can you assist here? What kind of annotation was this before the API went away? Was it an enum, something else? Can you give me an example/sample that works with APIs today?

[devoncarew]

@jwren, jup, looks like this code has changed. The new named parameter will be something like crossAxisAlignment:, and the valid values are CrossAxisAlignment enums (CrossAxisAlignment.start, end, center, stretch, baseline).

[devoncarew]

So, the problem is mostly likely that named params that are enums don't suggest the enum values.

[sethladd]

Sorry, I missed your ping.

That's what justifyContent is annotated for.

what kind of annotation do you want respected?

The type annotations on the parameters. In the example above, justifyContent has a type annotation for FlexJustifyContent. So, when trying to code complete a value for justifyContent, consider sorting/prioritizing FlexJustifyContent

Is it Flutter specific

Nope. Just a comment/suggestion around using Dart's type annotations.

[sethladd]

Looks like https://codereview.chromium.org/1989393002 was committed. Can we close this issue?

[sethladd]

Thanks!