web tests cannot handle scripts

[peter-ahe-google]

According to the Dart language specification, the #library tag is optional in a script. Our tests are scripts and do not require a #library tag.

Unfortunately, the dartium test component cannot handle scripts as it attempts to load the as libraries. This is not correct and makes it impossible to fully test the Dart language.

For example:

FAILED: dartium release_ia32 DummyCompilerTest
Expected: pass
Actual: fail

stdout:
CONSOLE MESSAGE: Internal error: 'api.dart');
^

Content-Type: text/plain
Running /mnt/data/b/build/slave/dartium-lucid64-inc/build/src/dart/tests/utils/src/DummyCompilerTest.dart

EOF

Command line: python /mnt/data/b/build/slave/dartium-lucid64-inc/build/src/dart/tools/testing/drt-trampoline.py /mnt/data/b/build/slave/dartium-lucid64-inc/build/src/out/Release/DumpRenderTree --no-timeout --dart-flags=--ignore-unrecognized-flags /mnt/data/b/build/slave/dartium-lucid64-inc/build/src/out/Release_ia32/generated_tests/dartium/tests_utils_src_DummyCompilerTest-/test.html

[whesse]

Added this to the Later milestone.

[peter-ahe-google]

This is breaking language/prefix_core_test.

Kasper is looking at this issue from a slightly different angle: changing the specification.

---

Set owner to @kasperl.
Removed this from the Later milestone.
Added this to the M1 milestone.

[peter-ahe-google]

I remain convinced that the root cause of this issue is the wrapping that is going in Dartium tests. I have demonstrated how to avoid wrapping in dart2js.

This bug reported more than 6 months ago and it continues to cause problems. The new library syntax is not helping. Currently Dartium will fail any test that uses library syntax without a #.

---

Removed Priority-Medium label.
Added Priority-High label.

[kasperl]

I still think that the right solution is to allow importing things that do not have a library name as long as they aren't marked as part of something else.

---

cc @gbracha.

[kasperl]

Removed this from the M1 milestone.
Added this to the M2 milestone.

[anders-sandholm]

Removed this from the M2 milestone.
Added this to the M3 milestone.

[gbracha]

FWIW, the spec allows (much to my regret) you to import a URI that does not designate a file with an explicitly named library declaration.

[anders-sandholm]

Removed this from the M3 milestone.
Added this to the M4 milestone.

[peter-ahe-google]

Fixed in r20971.

Unfortunately, we are still wrapping tests in Dartium :-(

---

Set owner to @peter-ahe-google.
Added Fixed label.