-
Notifications
You must be signed in to change notification settings - Fork 1.7k
registration order shouldn't matter as much #14459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
errr, registration order does matter :). Whoever gets upgraded first will see other elements un-upgraded. I don't know if that's the problem in the tests, or are you seeing something else? This might be a fatal flaw in our @CustomTag :| |
If no Polymer elements are expanded until all registrations have completed then the contract of all children being accessible when Polymer.ready is called will continue. |
yeah, I think in this case it's an issue with the <template> content, not with super/subclasses. |
The problem here is that we are getting multiple calls to ready() and created() for the same instance of a custom element. So far I've only been able to trigger this with custom-events and <content> propagation. I've attached a code sample that reproduces the problem. I was able to reproduce this without my partial changes to polymer events, btw. Attachment: |
err - the error doesn't repro without my changes in polymer-events, however, blink shouldn't do the 2 created calls regardless. |
Set owner to @sigmundch. |
Ok - the issue with duplicate 'ready' calls seems gone now in polymer 0.8.8. Removed this from the Later milestone. |
I managed to repro this problem again with event_path_declaration_test. I'll keep investigating. Added Triaged label. |
So it seems this is related to the GC issue Pete discovered. Attached is an updated version that forces GC to trigger the issue. Seems that we create the new wrapper as we walk up with 'parentNode' from the event target. Attachment: |
What really seems strange to me is that saving a reference to the existing node doesn't help. Try attached version instead. Attachment: |
Added AssumedStale label. |
Consider for example event_path_declaration_test.dart. If we swap the registration order of x-foo and x-bar we see additional unexpected calls to ready();
We need to investigate - this might be a problem in polymer.js as well.
The text was updated successfully, but these errors were encountered: