Skip to content

Pub should more efficiently serialize barback assets #14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nex3 opened this issue Oct 25, 2013 · 3 comments
Closed

Pub should more efficiently serialize barback assets #14430

nex3 opened this issue Oct 25, 2013 · 3 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@nex3
Copy link
Member

nex3 commented Oct 25, 2013

Currently when pub passes a barback asset between isolates, the contents of the asset is always streamed from one isolate to the other. There are two important optimizations that could be made here:

* The cross-isolate streaming could be kicked off only when the destination isolate tries to read the asset's contents, to prevent data being passed along that will go unused.

* FileAssets could be passed by name and loaded natively within the isolate accessing the file rather than piped from the main isolate.

@nex3
Copy link
Member Author

nex3 commented Oct 25, 2013

Marked this as blocking #13848.

@nex3
Copy link
Member Author

nex3 commented Nov 11, 2013

r29408 implements the first optimization and r30126 implements the second.


Added Fixed label.

@nex3 nex3 added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Nov 11, 2013
@nex3 nex3 self-assigned this Nov 11, 2013
@nex3 nex3 added this to the M8 milestone Nov 11, 2013
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#682.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

2 participants