Skip to content

Pub should more efficiently serialize barback assets #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 2 comments
Closed

Pub should more efficiently serialize barback assets #682

DartBot opened this issue Jun 5, 2015 · 2 comments
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#14430


Currently when pub passes a barback asset between isolates, the contents of the asset is always streamed from one isolate to the other. There are two important optimizations that could be made here:

* The cross-isolate streaming could be kicked off only when the destination isolate tries to read the asset's contents, to prevent data being passed along that will go unused.

* FileAssets could be passed by name and loaded natively within the isolate accessing the file rather than piped from the main isolate.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Marked this as blocking #647.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


dart-lang/sdk@c2790ca implements the first optimization and dart-lang/sdk@88124b3 implements the second.


Added Fixed label.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Fixed labels Jun 5, 2015
@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants