Skip to content

Adjacent strings expression in lists should be error, warning, or otherwise noticeable #14139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Oct 16, 2013 · 5 comments
Labels
devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Oct 16, 2013

This issue was originally filed by [email protected]


I have often run into bugs of the following form:

["a", "b", "c", "d" "e", "f"] // Can you notice a missing comma?

Without a close inspection, you easily conclude that the list declaration is correct.

A proposal:
Make it noticeable in the editor (color, etc.) when adjacent strings expression is used.
Considering making it an error or warning to use adjacent strings expression in list literals (and argument lists?).

@madsager
Copy link
Contributor

Added Area-Language, Triaged labels.

@gbracha
Copy link
Contributor

gbracha commented Aug 26, 2014

Reassigning to the editor,in case they can make it a hint. I was never a fan of the adjacent string concatenation idea, but we certainly aren't going to oscillate back and forth and make it illegal or a warning.


Removed Area-Language label.
Added Area-Editor label.

@sethladd
Copy link
Contributor

Adding some sort of visual indication seems reasonable. I, too, have been bit by this.


Removed Type-Defect, Area-Editor labels.
Added Type-Enhancement, Area-Analyzer labels.

@bwilkerson
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-Medium, Analyzer-Hint labels.

@DartBot DartBot added Type-Enhancement legacy-area-analyzer Use area-devexp instead. devexp-warning Issues with the analyzer's Warning codes labels Aug 27, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

Dup of #4979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants