Update navigation notification to support ConstructorReference.

Change-Id: I815941304f8dd131998f5ae527f21077ce5324df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212482
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/test/analysis/notification_navigation_test.dart

@@ -75,9 +75,10 @@ class AbstractNavigationTest extends AbstractAnalysisTest {
 
   /// Validates that there is an identifier region at [regionSearch] with target
   /// at [targetSearch].
-  void assertHasRegionTarget(String regionSearch, String targetSearch) {
+  void assertHasRegionTarget(String regionSearch, String targetSearch,
+      {int targetLength = -1}) {
     assertHasRegion(regionSearch);
-    assertHasTarget(targetSearch);
+    assertHasTarget(targetSearch, targetLength);
   }
 
   /// Validates that there is a target in [testTargets]  with [testFile], at the
@@ -391,6 +392,62 @@ class BBB {}
     assertHasRegionTarget('BBB p', 'BBB {}');
   }
 
+  Future<void> test_constructorReference_named() async {
+    addTestFile('''
+class A {}
+class B<T> {
+  B.named();
+}
+void f() {
+  B<A>.named;
+}
+''');
+    await prepareNavigation();
+    assertHasRegionTarget('B<A>.named;', 'named();');
+    assertHasRegionTarget('named;', 'named();');
+    assertHasRegionTarget('A>', 'A {}');
+  }
+
+  Future<void> test_constructorReference_unnamed_declared() async {
+    addTestFile('''
+class A {
+  A();
+}
+void f() {
+  A.new;
+}
+''');
+    await prepareNavigation();
+    assertHasRegionTarget('A.new;', 'A();', targetLength: 0);
+    assertHasRegionTarget('new;', 'A();', targetLength: 0);
+  }
+
+  Future<void> test_constructorReference_unnamed_declared_new() async {
+    addTestFile('''
+class A {
+  A.new();
+}
+void f() {
+  A.new;
+}
+''');
+    await prepareNavigation();
+    assertHasRegionTarget('A.new;', 'new();');
+    assertHasRegionTarget('new;', 'new();');
+  }
+
+  Future<void> test_constructorReference_unnamed_default() async {
+    addTestFile('''
+class A {}
+void f() {
+  A.new;
+}
+''');
+    await prepareNavigation();
+    assertHasRegionTarget('A.new;', 'A {}');
+    assertHasRegionTarget('new;', 'A {}');
+  }
+
   Future<void> test_enum_constant() async {
     addTestFile('''
 enum E { a, b }

pkg/analyzer/lib/src/dart/element/element.dart

@@ -1525,6 +1525,16 @@ class ConstructorElementImpl extends ExecutableElementImpl
   @override
   ElementKind get kind => ElementKind.CONSTRUCTOR;
 
+  @override
+  int get nameLength {
+    final nameEnd = this.nameEnd;
+    if (nameEnd == null || periodOffset == null) {
+      return 0;
+    } else {
+      return nameEnd - nameOffset;
+    }
+  }
+
   @override
   Element get nonSynthetic {
     return isSynthetic ? enclosingElement : this;

pkg/analyzer_plugin/lib/utilities/navigation/navigation_dart.dart

@@ -310,13 +310,27 @@ class _DartNavigationComputerVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitConstructorName(ConstructorName node) {
-    var parent = node.parent;
-    if (parent is InstanceCreationExpression &&
-        parent.constructorName == node) {
-      _addConstructorName(parent, node);
-    } else if (parent is ConstructorDeclaration &&
-        parent.redirectedConstructor == node) {
-      _addConstructorName(node, node);
+    Element? element = node.staticElement;
+    if (element == null) {
+      return;
+    }
+    // add regions
+    var typeName = node.type;
+    // [prefix].ClassName
+    {
+      var name = typeName.name;
+      var className = name;
+      if (name is PrefixedIdentifier) {
+        name.prefix.accept(this);
+        className = name.identifier;
+      }
+      computer._addRegionForNode(className, element);
+    }
+    // <TypeA, TypeB>
+    typeName.typeArguments?.accept(this);
+    // optional "name"
+    if (node.name != null) {
+      computer._addRegionForNode(node.name, element);
     }
   }
 
@@ -459,34 +473,6 @@ class _DartNavigationComputerVisitor extends RecursiveAstVisitor<void> {
     super.visitVariableDeclarationList(node);
   }
 
-  void _addConstructorName(AstNode parent, ConstructorName node) {
-    Element? element = node.staticElement;
-    if (element == null) {
-      return;
-    }
-    // add regions
-    var typeName = node.type;
-    // [prefix].ClassName
-    {
-      var name = typeName.name;
-      var className = name;
-      if (name is PrefixedIdentifier) {
-        name.prefix.accept(this);
-        className = name.identifier;
-      }
-      computer._addRegionForNode(className, element);
-    }
-    // <TypeA, TypeB>
-    var typeArguments = typeName.typeArguments;
-    if (typeArguments != null) {
-      typeArguments.accept(this);
-    }
-    // optional "name"
-    if (node.name != null) {
-      computer._addRegionForNode(node.name, element);
-    }
-  }
-
   /// If the source of the given [element] (referenced by the [node]) exists,
   /// then add the navigation region from the [node] to the [element].
   void _addUriDirectiveRegion(UriBasedDirective node, Element? element) {