Support for --cache in 'dart analyze'.

Bug: #45267
Change-Id: I503227ac59a3562e79d3654c405debaf5d0c764c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212420
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/dartdev/lib/src/analysis_server.dart

@@ -27,10 +27,12 @@ class AnalysisServer {
     this.packagesFile,
     this.sdkPath,
     this.analysisRoots, {
+    this.cacheDirectoryPath,
     @required this.commandName,
     @required this.argResults,
   });
 
+  final String cacheDirectoryPath;
   final File packagesFile;
   final Directory sdkPath;
   final List<FileSystemEntity> analysisRoots;
@@ -87,6 +89,7 @@ class AnalysisServer {
       '--disable-server-feature-search',
       '--sdk',
       sdkPath.path,
+      if (cacheDirectoryPath != null) '--cache=$cacheDirectoryPath',
       if (packagesFile != null) '--packages=${packagesFile.path}',
     ];
 

pkg/dartdev/lib/src/commands/analyze.dart

@@ -44,6 +44,12 @@ class AnalyzeCommand extends DartdevCommand {
           help: 'Treat warning level issues as fatal.', defaultsTo: true)
 
       // Options hidden by default.
+      ..addOption(
+        'cache',
+        valueHelp: 'path',
+        help: 'Override the location of the analysis cache.',
+        hide: !verbose,
+      )
       ..addOption(
         'format',
         valueHelp: 'value',
@@ -107,6 +113,7 @@ class AnalyzeCommand extends DartdevCommand {
       _packagesFile(),
       io.Directory(sdk.sdkPath),
       targets,
+      cacheDirectoryPath: argResults['cache'],
       commandName: 'analyze',
       argResults: argResults,
     );

pkg/dartdev/test/commands/analyze_test.dart

@@ -424,6 +424,22 @@ void f() {
     });
   });
 
+  test('--cache', () {
+    var cache = project(name: 'cache');
+
+    p = project(mainSrc: 'var v = 0;');
+    var result = p.runSync([
+      'analyze',
+      '--cache=${cache.dirPath}',
+      p.mainPath,
+    ]);
+
+    expect(result.exitCode, 0);
+    expect(result.stderr, isEmpty);
+    expect(result.stdout, contains('No issues found!'));
+    expect(cache.findDirectory('.analysis-driver'), isNotNull);
+  });
+
   group('display mode', () {
     final sampleInfoJson = {
       'severity': 'INFO',

pkg/dartdev/test/utils.dart

@@ -141,6 +141,11 @@ dev_dependencies:
   String get absolutePathToDartdevFile =>
       path.join(sdkRootPath, 'pkg', 'dartdev', 'bin', 'dartdev.dart');
 
+  Directory findDirectory(String name) {
+    var directory = Directory(path.join(dir.path, name));
+    return directory.existsSync() ? directory : null;
+  }
+
   File findFile(String name) {
     var file = File(path.join(dir.path, name));
     return file.existsSync() ? file : null;