Cleanup InferableOverride

We don't use this anymore.

[email protected]

Review URL: https://codereview.chromium.org/1296723002 .

Author: vsmenon

pkg/dev_compiler/lib/src/checker/checker.dart

@@ -295,34 +295,12 @@ class _OverrideChecker {
       //     get foo => e; // no type specified.
       //     toString() { ... } // no return type specified.
       //   }
-      if (_isInferableOverride(element, node, subType, baseType)) {
-        _recordMessage(new InferableOverride(errorLocation, element, type,
-            subType.returnType, baseType.returnType));
-      } else {
-        _recordMessage(new InvalidMethodOverride(
-            errorLocation, element, type, subType, baseType));
-      }
+      _recordMessage(new InvalidMethodOverride(
+          errorLocation, element, type, subType, baseType));
     }
     return true;
   }
 
-  bool _isInferableOverride(ExecutableElement element, AstNode node,
-      FunctionType subType, FunctionType baseType) {
-    if (_inferFromOverrides || node == null) return false;
-    final isGetter = element is PropertyAccessorElement && element.isGetter;
-    if (isGetter && element.isSynthetic) {
-      var field = node.parent.parent;
-      return field is FieldDeclaration && field.fields.type == null;
-    }
-
-    // node is a MethodDeclaration whenever getters and setters are
-    // declared explicitly. Setters declared from a field will have the
-    // correct return type, so we don't need to check that separately.
-    return node is MethodDeclaration &&
-        node.returnType == null &&
-        _rules.isFunctionSubTypeOf(subType, baseType, ignoreReturn: true);
-  }
-
   void _recordMessage(StaticInfo info) {
     if (info == null) return;
     var error = info.toAnalysisError();

pkg/dev_compiler/lib/src/info.dart

@@ -527,18 +527,6 @@ class InvalidMethodOverride extends InvalidOverride {
   String get message => _messageHelper('Invalid override');
 }
 
-// TODO(sigmund): delete, if we fix this, this should be part of the type
-// inference, not something we detect in the checker.
-// TODO(sigmund): split and track field, getter, setter, method separately
-class InferableOverride extends InvalidOverride {
-  InferableOverride(AstNode node, ExecutableElement element, InterfaceType base,
-      DartType subType, DartType baseType)
-      : super(node, element, base, subType, baseType);
-
-  toErrorCode() => new CompileTimeErrorCode(name, message);
-  String get message => _messageHelper('Invalid but inferable override');
-}
-
 /// Used to mark unexpected situations in our compiler were we couldn't compute
 /// the type of an expression.
 // TODO(sigmund): This is normally a result of another error that is caught by

pkg/dev_compiler/test/checker/checker_test.dart

@@ -1389,7 +1389,7 @@ void main() {
           class Child extends Base {
             /*severe:InvalidMethodOverride*/A f1; // invalid for getter
             /*severe:InvalidMethodOverride*/C f2; // invalid for setter
-            /*severe:InferableOverride,severe:InvalidMethodOverride*/var f3;
+            /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/var f3;
             /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/dynamic f4;
           }
        '''
@@ -1439,7 +1439,7 @@ void main() {
           class Child extends Base {
             /*severe:InvalidMethodOverride*/A get f1 => null;
             C get f2 => null;
-            /*severe:InferableOverride*/get f3 => null;
+            /*severe:InvalidMethodOverride*/get f3 => null;
             /*severe:InvalidMethodOverride*/dynamic get f4 => null;
           }
        '''
@@ -2489,7 +2489,7 @@ void main() {
         '/main.dart': '''
             class A {}
             class T1 implements A {
-                /*severe:InferableOverride*/toString() {}
+                /*severe:InvalidMethodOverride*/toString() {}
             }
          '''
       },

pkg/dev_compiler/test/checker/inferred_type_test.dart

@@ -737,7 +737,7 @@ void main() {
         }
 
         class B extends A {
-          /*severe:InferableOverride*/get x => 3;
+          /*severe:InvalidMethodOverride*/get x => 3;
         }
 
         foo() {
@@ -777,7 +777,7 @@ void main() {
         }
 
         class B implements A {
-          /*severe:InferableOverride*/get x => 3;
+          /*severe:InvalidMethodOverride*/get x => 3;
         }
 
         foo() {
@@ -841,7 +841,7 @@ void main() {
         }
 
         class B implements A<int> {
-          /*severe:InferableOverride*/get x => 3;
+          /*severe:InvalidMethodOverride*/get x => 3;
         }
 
         foo() {