[cfe] Report error when using a class as a mixin when sealed-class is enabled.

From the changes in dart-lang/language#2674 that specify from a certain language version, we would like classes to not be used as mixins unless specified as a 'mixin class'.

Currently, this behaviour is under the sealed-class flag. May be subject to change as the other modifiers are added, but I'd at least like to make sure this works for sealed classes.

Change-Id: I5754b383327dde06d49175fe2d05c8ba7462145f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273082
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -905,6 +905,27 @@ Message _withArgumentsCantReadFile(Uri uri_, String string) {
       arguments: {'uri': uri_, 'string': string});
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(String name)> templateCantUseClassAsMixin =
+    const Template<Message Function(String name)>(
+        problemMessageTemplate: r"""Class '#name' can't be used as a mixin.""",
+        withArguments: _withArgumentsCantUseClassAsMixin);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(String name)> codeCantUseClassAsMixin =
+    const Code<Message Function(String name)>(
+  "CantUseClassAsMixin",
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsCantUseClassAsMixin(String name) {
+  if (name.isEmpty) throw 'No name provided';
+  name = demangleMixinApplicationName(name);
+  return new Message(codeCantUseClassAsMixin,
+      problemMessage: """Class '${name}' can't be used as a mixin.""",
+      arguments: {'name': name});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(Token token)>
     templateCantUseControlFlowOrSpreadAsConstant =

pkg/front_end/lib/src/fasta/source/source_loader.dart

@@ -2069,44 +2069,60 @@ severity: $severity
               noLength);
         }
       } else if (supertype is ClassBuilder &&
-          supertype.isSealed &&
-          supertype.libraryBuilder.origin != cls.libraryBuilder.origin) {
-        // If the class is a mixin declaration with an `on` clause which is the
-        // supertype we are evaluating right now, we want to avoid reporting an
-        // error.
-        bool superTypeIsOnClause = false;
-        if (cls.cls.isAnonymousMixin && !cls.cls.isEliminatedMixin) {
-          // The class has multiple 'on' clauses.
-          List<TypeBuilder>? classInterfaces = cls.interfaceBuilders;
-          if (classInterfaces != null) {
-            for (TypeBuilder interface in classInterfaces) {
-              if (interface.declaration == supertype) {
-                superTypeIsOnClause = true;
-                break;
+          cls.libraryBuilder.libraryFeatures.sealedClass.isEnabled) {
+        // Check for implicit class mixins.
+        TypeBuilder? mixedInType = cls.mixedInTypeBuilder;
+        if (cls.isMixinApplication &&
+            mixedInType != null &&
+            mixedInType.declaration == supertype &&
+            !supertype.isMixinDeclaration) {
+          cls.addProblem(
+              templateCantUseClassAsMixin
+                  .withArguments(supertype.fullNameForErrors),
+              cls.charOffset,
+              noLength);
+        }
+
+        // Report error for subtyping outside of sealed supertype's library.
+        if (supertype.isSealed &&
+            supertype.libraryBuilder.origin != cls.libraryBuilder.origin) {
+          // If the class is a mixin declaration with an `on` clause which is
+          // the supertype we are evaluating right now, we want to avoid
+          // reporting an error.
+          bool superTypeIsOnClause = false;
+          if (cls.cls.isAnonymousMixin && !cls.cls.isEliminatedMixin) {
+            // The class has multiple 'on' clauses.
+            List<TypeBuilder>? classInterfaces = cls.interfaceBuilders;
+            if (classInterfaces != null) {
+              for (TypeBuilder interface in classInterfaces) {
+                if (interface.declaration == supertype) {
+                  superTypeIsOnClause = true;
+                  break;
+                }
               }
             }
+          } else if (cls.isMixinDeclaration) {
+            // The class has up to one 'on' clause.
+            TypeBuilder? classSuperType = cls.supertypeBuilder;
+            if (classSuperType != null &&
+                classSuperType.declaration == supertype) {
+              superTypeIsOnClause = true;
+            }
           }
-        } else if (cls.isMixinDeclaration) {
-          // The class has up to one 'on' clause.
-          TypeBuilder? classSuperType = cls.supertypeBuilder;
-          if (classSuperType != null &&
-              classSuperType.declaration == supertype) {
-            superTypeIsOnClause = true;
-          }
-        }
-        if (!superTypeIsOnClause) {
-          if (supertype.isMixinDeclaration) {
-            cls.addProblem(
-                templateSealedMixinSubtypeOutsideOfLibrary
-                    .withArguments(supertype.fullNameForErrors),
-                cls.charOffset,
-                noLength);
-          } else {
-            cls.addProblem(
-                templateSealedClassSubtypeOutsideOfLibrary
-                    .withArguments(supertype.fullNameForErrors),
-                cls.charOffset,
-                noLength);
+          if (!superTypeIsOnClause) {
+            if (supertype.isMixinDeclaration) {
+              cls.addProblem(
+                  templateSealedMixinSubtypeOutsideOfLibrary
+                      .withArguments(supertype.fullNameForErrors),
+                  cls.charOffset,
+                  noLength);
+            } else {
+              cls.addProblem(
+                  templateSealedClassSubtypeOutsideOfLibrary
+                      .withArguments(supertype.fullNameForErrors),
+                  cls.charOffset,
+                  noLength);
+            }
           }
         }
       }

pkg/front_end/messages.status

@@ -64,6 +64,7 @@ CantInferPackagesFromPackageUri/analyzerCode: Fail
 CantInferPackagesFromPackageUri/example: Fail
 CantInferTypeDueToCircularity/example: Fail
 CantReadFile/part_wrapped_script: Fail # Importing file in the (now) part.
+CantUseClassAsMixin/analyzerCode: Fail
 CantUseControlFlowOrSpreadAsConstant/example: Fail
 CantUseDeferredPrefixAsConstant/part_wrapped_script: Fail # Importing file in the (now) part.
 CantUsePrefixAsExpression/part_wrapped_script: Fail # Importing file in the (now) part.

pkg/front_end/messages.yaml

@@ -6021,3 +6021,10 @@ SealedMixinSubtypeOutsideOfLibrary:
       class B with M {}
     lib.dart:
       sealed mixin M {}
+
+CantUseClassAsMixin:
+  problemMessage: "Class '#name' can't be used as a mixin."
+  experiments: sealed-class
+  script: |
+    class A {}
+    class B with A {}

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.strong.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.strong.transformed.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.weak.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.weak.modular.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.weak.outline.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^

pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart.weak.transformed.expect

@@ -10,6 +10,10 @@ library /*isNonNullableByDefault*/;
 // class Class2 implements Sealed {}
 //       ^
 //
+// pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Class 'Sealed' can't be used as a mixin.
+// class Class3 with Sealed {}
+//       ^
+//
 // pkg/front_end/testcases/sealed_class/extends_implements_with/main.dart:11:7: Error: Sealed class 'Sealed' can't be extended, implemented, or mixed in outside of its library.
 // class Class3 with Sealed {}
 //       ^