Fix pedantic 0.9 lints around collection literals and spreads

Change-Id: I64277c36fbeb4ea7a1bb429a8e0a40203520c883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128380
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analyzer/lib/dart/ast/ast.dart

@@ -3069,8 +3069,8 @@ abstract class ImportDirective implements NamespaceDirective {
     // hides and shows
     //
     NodeList<Combinator> combinators1 = import1.combinators;
-    List<String> allHides1 = List<String>();
-    List<String> allShows1 = List<String>();
+    List<String> allHides1 = <String>[];
+    List<String> allShows1 = <String>[];
     int length1 = combinators1.length;
     for (int i = 0; i < length1; i++) {
       Combinator combinator = combinators1[i];
@@ -3092,8 +3092,8 @@ abstract class ImportDirective implements NamespaceDirective {
       }
     }
     NodeList<Combinator> combinators2 = import2.combinators;
-    List<String> allHides2 = List<String>();
-    List<String> allShows2 = List<String>();
+    List<String> allHides2 = <String>[];
+    List<String> allShows2 = <String>[];
     int length2 = combinators2.length;
     for (int i = 0; i < length2; i++) {
       Combinator combinator = combinators2[i];

pkg/analyzer/lib/error/listener.dart

@@ -217,8 +217,8 @@ class ErrorReporter {
         Map<String, Set<Element>> nameToElementMap = {};
         for (_TypeToConvert typeToConvert in typeGroup) {
           for (Element element in typeToConvert.allElements()) {
-            Set<Element> elements = nameToElementMap.putIfAbsent(
-                element.name, () => Set<Element>());
+            Set<Element> elements =
+                nameToElementMap.putIfAbsent(element.name, () => <Element>{});
             elements.add(element);
           }
         }
@@ -311,7 +311,7 @@ class _TypeToConvert {
 
   List<Element> allElements() {
     if (_allElements == null) {
-      Set<Element> elements = Set<Element>();
+      Set<Element> elements = <Element>{};
 
       void addElementsFrom(DartType type) {
         if (type is FunctionType) {

pkg/analyzer/lib/src/dart/analysis/cache.dart

@@ -2,16 +2,14 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:collection';
-
 /**
  * LRU cache of objects.
  */
 class Cache<K, V> {
   final int _maxSizeBytes;
   final int Function(V) _meter;
 
-  final _map = LinkedHashMap<K, V>();
+  final _map = <K, V>{};
   int _currentSizeBytes = 0;
 
   Cache(this._maxSizeBytes, this._meter);

pkg/analyzer/lib/src/dart/analysis/defined_names.dart

@@ -51,6 +51,6 @@ DefinedNames computeDefinedNames(CompilationUnit unit) {
  * Defined top-level and class member names.
  */
 class DefinedNames {
-  final Set<String> topLevelNames = Set<String>();
-  final Set<String> classMemberNames = Set<String>();
+  final Set<String> topLevelNames = <String>{};
+  final Set<String> classMemberNames = <String>{};
 }

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:collection';
 import 'dart:typed_data';
 
 import 'package:analyzer/dart/analysis/analysis_context.dart' as api;
@@ -151,7 +150,7 @@ class AnalysisDriver implements AnalysisDriverGeneric {
       2 + AnalysisOptions.signatureLength + _declaredVariablesSignatureLength);
 
   /// The set of priority files, that should be analyzed sooner.
-  final _priorityFiles = LinkedHashSet<String>();
+  final _priorityFiles = <String>{};
 
   /// The mapping from the files for which analysis was requested using
   /// [getResult] to the [Completer]s to report the result.
@@ -204,7 +203,7 @@ class AnalysisDriver implements AnalysisDriverGeneric {
   final _requestedParts = <String, List<Completer<ResolvedUnitResult>>>{};
 
   /// The set of part files that are currently scheduled for analysis.
-  final _partsToAnalyze = LinkedHashSet<String>();
+  final _partsToAnalyze = <String>{};
 
   /// The controller for the [results] stream.
   final _resultController = StreamController<ResolvedUnitResult>();
@@ -1722,7 +1721,7 @@ class AnalysisDriver implements AnalysisDriverGeneric {
       String min = _twoDigits(time.minute);
       String sec = _twoDigits(time.second);
       String ms = _threeDigits(time.millisecond);
-      String key = 'exception_${time.year}$m$d' '_$h$min$sec' + '_$ms';
+      String key = 'exception_${time.year}$m${d}_$h$min${sec}_$ms';
 
       _byteStore.put(key, bytes);
       return key;
@@ -2202,7 +2201,7 @@ class _FilesDefiningClassMemberNameTask {
   final Completer<List<String>> completer = Completer<List<String>>();
 
   final List<String> definingFiles = <String>[];
-  final Set<String> checkedFiles = Set<String>();
+  final Set<String> checkedFiles = <String>{};
   final List<String> filesToCheck = <String>[];
 
   _FilesDefiningClassMemberNameTask(this.driver, this.name);

pkg/analyzer/lib/src/dart/analysis/file_state.dart

@@ -301,7 +301,7 @@ class FileState {
    * directly or indirectly referenced files.
    */
   Set<FileState> get transitiveFiles {
-    var transitiveFiles = Set<FileState>();
+    var transitiveFiles = <FileState>{};
 
     void appendReferenced(FileState file) {
       if (transitiveFiles.add(file)) {
@@ -487,22 +487,24 @@ class FileState {
           .putIfAbsent(file, () => <FileState>[])
           .add(this);
     }
-    _libraryFiles = [this]..addAll(_partedFiles);
+    _libraryFiles = [this, ..._partedFiles];
 
     // Compute referenced files.
-    _directReferencedFiles = Set<FileState>()
-      ..addAll(_importedFiles)
-      ..addAll(_exportedFiles)
-      ..addAll(_partedFiles);
-    _directReferencedLibraries = Set<FileState>()
-      ..addAll(_importedFiles)
-      ..addAll(_exportedFiles);
+    _directReferencedFiles = <FileState>{
+      ..._importedFiles,
+      ..._exportedFiles,
+      ..._partedFiles,
+    };
+    _directReferencedLibraries = <FileState>{
+      ..._importedFiles,
+      ..._exportedFiles,
+    };
 
     // Update mapping from subtyped names to files.
     for (var name in _driverUnlinkedUnit.subtypedNames) {
       var files = _fsState._subtypedNameToFiles[name];
       if (files == null) {
-        files = Set<FileState>();
+        files = <FileState>{};
         _fsState._subtypedNameToFiles[name] = files;
       }
       files.add(this);
@@ -735,7 +737,7 @@ class FileSystemState {
   /**
    * All known file paths.
    */
-  final Set<String> knownFilePaths = Set<String>();
+  final Set<String> knownFilePaths = <String>{};
 
   /**
    * All known files.

pkg/analyzer/lib/src/dart/analysis/file_tracker.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:collection';
-
 import 'package:analyzer/src/dart/analysis/file_state.dart';
 import 'package:analyzer/src/dart/analysis/performance_logger.dart';
 
@@ -47,37 +45,37 @@ class FileTracker {
   /**
    * The set of added files.
    */
-  final addedFiles = LinkedHashSet<String>();
+  final addedFiles = <String>{};
 
   /**
    * The set of files were reported as changed through [changeFile] and not
    * checked for actual changes yet.
    */
-  final _changedFiles = LinkedHashSet<String>();
+  final _changedFiles = <String>{};
 
   /**
    * The set of files that are currently scheduled for analysis, which were
    * reported as changed through [changeFile].
    */
-  var _pendingChangedFiles = LinkedHashSet<String>();
+  var _pendingChangedFiles = <String>{};
 
   /**
    * The set of files that are currently scheduled for analysis, which directly
    * import a changed file.
    */
-  var _pendingImportFiles = LinkedHashSet<String>();
+  var _pendingImportFiles = <String>{};
 
   /**
    * The set of files that are currently scheduled for analysis, which have an
    * error or a warning, which might be fixed by a changed file.
    */
-  var _pendingErrorFiles = LinkedHashSet<String>();
+  var _pendingErrorFiles = <String>{};
 
   /**
    * The set of files that are currently scheduled for analysis, and don't
    * have any special relation with changed files.
    */
-  var _pendingFiles = LinkedHashSet<String>();
+  var _pendingFiles = <String>{};
 
   FileTracker(this._logger, this._fsState, this._changeHook);
 
@@ -238,10 +236,10 @@ class FileTracker {
       if (anyApiChanged) {
         _logger.writeln('API signatures mismatch found.');
         // TODO(scheglov) schedule analysis of only affected files
-        var pendingChangedFiles = LinkedHashSet<String>();
-        var pendingImportFiles = LinkedHashSet<String>();
-        var pendingErrorFiles = LinkedHashSet<String>();
-        var pendingFiles = LinkedHashSet<String>();
+        var pendingChangedFiles = <String>{};
+        var pendingImportFiles = <String>{};
+        var pendingErrorFiles = <String>{};
+        var pendingFiles = <String>{};
 
         // Add the changed file.
         if (addedFiles.contains(path)) {

pkg/analyzer/lib/src/dart/analysis/index.dart

@@ -884,7 +884,7 @@ class _IndexContributor extends GeneralizingAstVisitor {
    */
   ConstructorElement _getActualConstructorElement(
       ConstructorElement constructor) {
-    Set<ConstructorElement> seenConstructors = Set<ConstructorElement>();
+    Set<ConstructorElement> seenConstructors = <ConstructorElement>{};
     while (constructor != null &&
         constructor.isSynthetic &&
         constructor.redirectedConstructor != null) {

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

@@ -94,9 +94,9 @@ class LibraryAnalyzer {
    *
    * TODO(scheglov) Remove after https://github.com/dart-lang/sdk/issues/31925
    */
-  final Set<ConstantEvaluationTarget> _libraryConstants = Set();
+  final Set<ConstantEvaluationTarget> _libraryConstants = {};
 
-  final Set<ConstantEvaluationTarget> _constants = Set();
+  final Set<ConstantEvaluationTarget> _constants = {};
 
   LibraryAnalyzer(
       this._analysisOptions,
@@ -558,7 +558,7 @@ class LibraryAnalyzer {
     ErrorReporter libraryErrorReporter = _getErrorReporter(_library);
 
     LibraryIdentifier libraryNameNode;
-    var seenPartSources = Set<Source>();
+    var seenPartSources = <Source>{};
     var directivesToResolve = <Directive>[];
     int partIndex = 0;
     for (Directive directive in definingCompilationUnit.directives) {

pkg/analyzer/lib/src/dart/analysis/library_graph.dart

@@ -22,7 +22,7 @@ class LibraryCycle {
   final List<FileState> libraries = [];
 
   /// The library cycles that this cycle references directly.
-  final Set<LibraryCycle> directDependencies = Set<LibraryCycle>();
+  final Set<LibraryCycle> directDependencies = <LibraryCycle>{};
 
   /// The cycles that use this cycle, used to [invalidate] transitively.
   final List<LibraryCycle> _directUsers = [];