@visibleForOverriding should not hint on calling super.

Fixes #48626

Change-Id: Ie0b7d1e8f92ab5ecfc03e60635ab89ea4b99f0d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239432
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: asashour

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -1962,8 +1962,22 @@ class _InvalidAccessVerifier {
     }
 
     if (hasVisibleForOverriding) {
-      _errorReporter.reportErrorForNode(
-          HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, node, [name]);
+      var parent = node.parent;
+      var validOverride = false;
+      if (parent is MethodInvocation && parent.target is SuperExpression ||
+          parent is PropertyAccess && parent.target is SuperExpression) {
+        var methodDeclaration =
+            grandparent?.thisOrAncestorOfType<MethodDeclaration>();
+        if (methodDeclaration?.name.token.value() == identifier.token.value()) {
+          validOverride = true;
+        }
+      }
+      if (!validOverride) {
+        _errorReporter.reportErrorForNode(
+            HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER,
+            node,
+            [name]);
+      }
     }
   }
 

pkg/analyzer/test/src/diagnostics/invalid_use_of_visible_for_overriding_member_test.dart

@@ -88,9 +88,125 @@ class Child extends Parent {
 ''');
   }
 
+  test_getter() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  int get g => 0;
+}
+''');
+
+    await assertErrorsInCode('''
+import 'a.dart';
+
+class B {
+  int m(A a) {
+    return a.g;
+  }
+}
+''', [
+      error(HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, 56, 1),
+    ]);
+  }
+
+  test_overriding_getter() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  int get g => 0;
+}
+''');
+
+    await assertErrorsInCode('''
+import 'a.dart';
+
+class B extends A {
+  @override
+  int get g => super.g + 1;
+
+  int get x => super.g + 1;
+}
+''', [
+      error(HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, 100, 1),
+    ]);
+  }
+
+  test_overriding_methodInvocation() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  void m() {}
+}
+''');
+
+    await assertErrorsInCode('''
+import 'a.dart';
+
+class B extends A {
+  @override
+  void m() => super.m();
+
+  void x() => super.m();
+}
+''', [
+      error(HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, 96, 1),
+    ]);
+  }
+
+  test_overriding_operator() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  operator >(A other) => true;
+}
+''');
+
+    await assertNoErrorsInCode('''
+import 'a.dart';
+
+class B extends A {
+  @override
+  operator >(A other) => super > other;
+}
+''');
+  }
+
+  test_overriding_setter() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  set s(int i) {}
+}
+''');
+
+    await assertErrorsInCode('''
+import 'a.dart';
+
+class B extends A {
+  @override
+  set s(int i) => super.s = i;
+
+  set x(int i) => super.s = i;
+}
+''', [
+      error(HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, 106, 1),
+    ]);
+  }
+
   test_sameLibrary() async {
     await assertNoErrorsInCode('''
 import 'package:meta/meta.dart';
+
 class Parent {
   @visibleForOverriding
   void foo() {}
@@ -103,4 +219,27 @@ class Child extends Parent {
 }
 ''');
   }
+
+  test_setter() async {
+    newFile2('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  set s(int i) {}
+}
+''');
+
+    await assertErrorsInCode('''
+import 'a.dart';
+
+class B {
+  void m(A a) {
+    a.s = 1;
+  }
+}
+''', [
+      error(HintCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER, 50, 1),
+    ]);
+  }
 }