Skip to content

Handle failure to retrieve status when testing advisory cache age #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Handle failure to retrieve status when testing advisory cache age #4337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/src/source/hosted.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,14 @@ class HostedSource extends CachedSource {
}
final parsedCacheAdvisoriesUpdated =
DateTime.parse(cachedAdvisoriesUpdated);
if ((await status(id.toRef(), id.version, cache))
.advisoriesUpdated!
.isAfter(parsedCacheAdvisoriesUpdated)) {
// too old
final advisoriesUpdated =
(await status(id.toRef(), id.version, cache)).advisoriesUpdated;

if (
// We could not obtain the timestamp of latest advisory update.
advisoriesUpdated == null ||
// The cached entry is too old.
advisoriesUpdated.isAfter(parsedCacheAdvisoriesUpdated)) {
tryDeleteEntry(advisoriesCachePath);
} else {
return _extractAdvisoryDetailsForPackage(doc, id.toRef().name);
Expand Down