Parallel fetching of available versions #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
force-pushed
the
parallel_get
branch
from
8cad905 to
3a86142
Compare
|
This messes up the zones. That needs to be fixed to land this. |
|
the zones should work correctly now |
|
Fixes #2147 \o/ |
jonasfj
reviewed
Dec 17, 2019
jonasfj
reviewed
Dec 23, 2019
jonasfj
reviewed
Dec 30, 2019
natebosch
requested changes
Jan 2, 2020
jonasfj
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
@natebosch, if you have any more drive-by comments now is the time to make them, otherwise we'll land this :)
|
oh, I guess we'll also have to fix the travis tests.. but we'll land this soon :) |
natebosch
approved these changes
Jan 13, 2020
lib/src/rate_limited_scheduler.dart
Outdated
| if (_started.contains(task.jobId)) { | ||
| return; | ||
| } | ||
| _started.add(task.jobId); |
There was a problem hiding this comment.
[nit] I usually prefer to skip the .contains before a .add on a Set.
if (!_started.add(task.jobId)) {
return;
}| } | ||
| _started.add(task.jobId); | ||
|
|
||
| Future<V> runJob() async { |
There was a problem hiding this comment.
Why do we need a separate function for this? Can we instead do
completer.complete(task.zone.runUnary(_runJob, task.jobId));There was a problem hiding this comment.
It is to handle the case that _runJob throws sync exceptions
Added an explanatory comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rate-limited parallel fetching of version information when solving.
Also does speculative pre-fetching of version information of dependencies of the newest versions of each package.
In informal benchmarks of
pub getfor a package whose only direct dependency is package:test the resolution time goes from 7.8 seconds to 1.5 seconds.Also adds package:pedantic to our runtime dependencies