Pub run should support passing in flags to vm

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2192312?v=3" align="left" width="96" height="96"hspace="10"> Issue by keertip
Originally opened as dart-lang/sdk#19569

---

A typical invocation of the vm to run command line apps from DartEditor would look like

dart --enable-checked-mode --debug:50677 --enable-vm-service:50678 --trace_service_pause_events --pause-isolates-on-start myapp.dart

and any other that the user may specify

DartEditor should be able to specify arguments to pass on to the vm when starting pub run from the editor.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent

---

Relatively soon, I want pub run to change from spawning a process to spawning an isolate for the entrypoint being run. (See: https://code.google.com/p/dart/issues/detail?id=19438).

If that happens, we wouldn't be able to have separate VM flags for the spawned app. Would it make sense to spawn the pub process itself with these settings? That would mean the user is also implicitly debugging pub. This could be good if they want to see what transformers are doing, but may be confusing otherwise.

What do you think?

---

cc @nex3.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-High labels.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl

---

Added this to the 1.6 milestone.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent

---

Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/3766663?v=3" align="left" width="48" height="48"hspace="10"> Comment by nicolasgarnier

---

I would also need this for the test runner to be able to gather code coverage data from tests.

I guess that would still be OK with isolates though just a bit more handling/filtering to do.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

Does the test runner run via pub run? Is that why you need it?

[DartBot]

<img src="https://avatars.githubusercontent.com/u/3766663?v=3" align="left" width="48" height="48"hspace="10"> Comment by nicolasgarnier

---

The test runner runs Standalone VM test (aka non Browser tests) using "pub run" and browser tests using "pub serve" that allows us to make sure eventual transformers are applied without having to run "pub build" first.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/3766663?v=3" align="left" width="48" height="48"hspace="10"> Comment by nicolasgarnier

---

By the way it would be great if we could also have "pub run" run the VM in un-checked mode (currently it always runs in checked mode). I'm asking about that here because it seem related (you could just make that a flag you optionally pass to the underlying VM)

[DartBot]

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

---

When we add support for this, we'll definitely allow explicit control of checked mode as well.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

See also http://stackoverflow.com/questions/28093559/how-do-i-set-the-dart2js-minify-option-from-the-command-line-when-executing-p?stw=2

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

Possibly blocked by https://code.google.com/p/dart/issues/detail?id=21791 ?