Run dartfmt --fix to drop new and const (#1962)

Enable the `unnecessary_new` lint to prevent regressions.

Author: natebosch

analysis_options.yaml

@@ -49,6 +49,7 @@ linter:
     - type_init_formals
     - unnecessary_brace_in_string_interps
     - unnecessary_getters_setters
+    - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_statements
     - unnecessary_this

bin/pub.dart

@@ -5,5 +5,5 @@
 import 'package:pub/src/command_runner.dart';
 
 void main(List<String> arguments) {
-  new PubCommandRunner().run(arguments);
+  PubCommandRunner().run(arguments);
 }

lib/src/ascii_tree.dart

@@ -99,7 +99,7 @@ String fromFiles(List<String> files, {String baseDir, bool showAllChildren}) {
 /// If [showAllChildren] is `false`, then directories with more than ten items
 /// will have their contents truncated. Defaults to `false`.
 String fromMap(Map<String, Map> map, {bool showAllChildren}) {
-  var buffer = new StringBuffer();
+  var buffer = StringBuffer();
   _draw(buffer, "", null, map, showAllChildren: showAllChildren);
   return buffer.toString();
 }

lib/src/command.dart

@@ -16,19 +16,19 @@ import 'system_cache.dart';
 /// of subcommands. Only leaf commands are ever actually invoked. If a command
 /// has subcommands, then one of those must always be chosen.
 abstract class PubCommand extends Command {
-  SystemCache get cache => _cache ??= new SystemCache(isOffline: isOffline);
+  SystemCache get cache => _cache ??= SystemCache(isOffline: isOffline);
 
   SystemCache _cache;
 
-  GlobalPackages get globals => _globals ??= new GlobalPackages(cache);
+  GlobalPackages get globals => _globals ??= GlobalPackages(cache);
 
   GlobalPackages _globals;
 
   /// Gets the [Entrypoint] package for the current working directory.
   ///
   /// This will load the pubspec and fail with an error if the current directory
   /// is not a package.
-  Entrypoint get entrypoint => _entrypoint ??= new Entrypoint.current(cache);
+  Entrypoint get entrypoint => _entrypoint ??= Entrypoint.current(cache);
 
   Entrypoint _entrypoint;
 
@@ -42,7 +42,7 @@ abstract class PubCommand extends Command {
   // Lazily initialize the parser because the superclass constructor requires
   // it but we want to initialize it based on [allowTrailingOptions].
   ArgParser get argParser =>
-      _argParser ??= new ArgParser(allowTrailingOptions: allowTrailingOptions);
+      _argParser ??= ArgParser(allowTrailingOptions: allowTrailingOptions);
 
   ArgParser _argParser;
 

lib/src/command/cache.dart

@@ -15,8 +15,8 @@ class CacheCommand extends PubCommand {
   String get docUrl => "http://dartlang.org/tools/pub/cmd/pub-cache.html";
 
   CacheCommand() {
-    addSubcommand(new CacheAddCommand());
-    addSubcommand(new CacheListCommand());
-    addSubcommand(new CacheRepairCommand());
+    addSubcommand(CacheAddCommand());
+    addSubcommand(CacheListCommand());
+    addSubcommand(CacheRepairCommand());
   }
 }

lib/src/command/cache_add.dart

@@ -44,7 +44,7 @@ class CacheAddCommand extends PubCommand {
     var constraint = VersionConstraint.any;
     if (argResults["version"] != null) {
       try {
-        constraint = new VersionConstraint.parse(argResults["version"]);
+        constraint = VersionConstraint.parse(argResults["version"]);
       } on FormatException catch (error) {
         usageException(error.message);
       }

lib/src/command/cache_repair.dart

@@ -39,7 +39,7 @@ class CacheRepairCommand extends PubCommand {
 
     if (failures.isNotEmpty) {
       var packages = pluralize("package", failures.length);
-      var buffer = new StringBuffer(
+      var buffer = StringBuffer(
           "Failed to reinstall ${log.red(failures.length)} $packages:\n");
 
       for (var id in failures) {

lib/src/command/deps.dart

@@ -24,7 +24,7 @@ class DepsCommand extends PubCommand {
   bool get takesArguments => false;
 
   final AnalysisContextManager analysisContextManager =
-      new AnalysisContextManager();
+      AnalysisContextManager();
 
   /// The [StringBuffer] used to accumulate the output.
   StringBuffer _buffer;
@@ -52,7 +52,7 @@ class DepsCommand extends PubCommand {
     // Explicitly run this in case we don't access `entrypoint.packageGraph`.
     entrypoint.assertUpToDate();
 
-    _buffer = new StringBuffer();
+    _buffer = StringBuffer();
 
     if (argResults['executables']) {
       _outputExecutables();
@@ -166,8 +166,8 @@ class DepsCommand extends PubCommand {
     // The work list for the breadth-first traversal. It contains the package
     // being added to the tree, and the parent map that will receive that
     // package.
-    var toWalk = new Queue<Pair<Package, Map<String, Map>>>();
-    var visited = new Set<String>.from([entrypoint.root.name]);
+    var toWalk = Queue<Pair<Package, Map<String, Map>>>();
+    var visited = Set<String>.from([entrypoint.root.name]);
 
     // Start with the root dependencies.
     var packageTree = <String, Map>{};
@@ -177,7 +177,7 @@ class DepsCommand extends PubCommand {
       immediateDependencies.removeAll(entrypoint.root.devDependencies.keys);
     }
     for (var name in immediateDependencies) {
-      toWalk.add(new Pair(_getPackage(name), packageTree));
+      toWalk.add(Pair(_getPackage(name), packageTree));
     }
 
     // Do a breadth-first walk to the dependency graph.
@@ -198,7 +198,7 @@ class DepsCommand extends PubCommand {
       map[_labelPackage(package)] = childMap;
 
       for (var dep in package.dependencies.values) {
-        toWalk.add(new Pair(_getPackage(dep.name), childMap));
+        toWalk.add(Pair(_getPackage(dep.name), childMap));
       }
     }
 

lib/src/command/global.dart

@@ -15,9 +15,9 @@ class GlobalCommand extends PubCommand {
   String get invocation => "pub global <subcommand>";
 
   GlobalCommand() {
-    addSubcommand(new GlobalActivateCommand());
-    addSubcommand(new GlobalDeactivateCommand());
-    addSubcommand(new GlobalListCommand());
-    addSubcommand(new GlobalRunCommand());
+    addSubcommand(GlobalActivateCommand());
+    addSubcommand(GlobalDeactivateCommand());
+    addSubcommand(GlobalListCommand());
+    addSubcommand(GlobalRunCommand());
   }
 }

lib/src/command/global_activate.dart

@@ -98,7 +98,7 @@ class GlobalActivateCommand extends PubCommand {
         var constraint = VersionConstraint.any;
         if (args.isNotEmpty) {
           try {
-            constraint = new VersionConstraint.parse(readArg());
+            constraint = VersionConstraint.parse(readArg());
           } on FormatException catch (error) {
             usageException(error.message);
           }