Skip to content

Tool for local SDK search index benchmark #8751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented May 12, 2025

  • SDK search index improvements (tracking issue) #8670
  • This tool is similar to https://github.com/dart-lang/pub-dev/blob/master/app/bin/tools/search_benchmark.dart only for SDK indexes, using the Flutter index by default, as it is larger.
  • The local profiling showed that most time is spent in the top-k (top-3) result selection. I didn't see any trivial changes there that improved the outcome.
  • The overall time spent in the SDK search method is less than 2 ms on my localhost - it is likely not a big contributor to search latencies (which were in the 30-40 ms range last time I've checked). Still, it may be worth to look into top-k selection, as the regular search index also uses it when sorting/selecting the results.

@isoos isoos requested review from jonasfj and sigurdm May 12, 2025 15:16
@isoos isoos merged commit 73f43ae into dart-lang:master May 13, 2025
31 checks passed
@isoos isoos deleted the sdk-benchmark branch May 13, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants