Skip to content

Check the saved file length + md5 hash at upload processing. #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented May 1, 2025

  • The length check is cheap and catches trivial issues.
  • The md5 check seems to be better than the CRC32, and should provide more confidence.

@isoos isoos requested review from jonasfj and sigurdm May 1, 2025 13:21
@isoos isoos merged commit c01b547 into dart-lang:master May 1, 2025
31 checks passed
@isoos isoos deleted the upload-crc branch May 1, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants