Skip to content

Bump of dart-doc size-limit #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Bump of dart-doc size-limit #6381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d6df05
Bump of dart-doc size-limit
sigurdm Jan 30, 2023
ab8941e
Make it 300 megs
sigurdm Jan 30, 2023
292e363
Merge remote-tracking branch 'origin/master' into bump_dartdoc_size_l…
sigurdm Feb 2, 2023
63e226b
Update CHANGELOG.md
sigurdm Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ AppEngine version, listed here to ease deployment and troubleshooting.
* Upgraded dartdoc to `6.1.5`.
* Upgraded dependencies.
* Updated `osd.xml`: using inlined URL parameter.
* Higher limit on dart-doc total output size (2.3G).

## `20230125t151100-all`
* Enabled `dart3` experiment, displaying "Dart-3 ready" badges.
Expand Down
6 changes: 5 additions & 1 deletion pkg/pub_dartdoc/lib/src/pub_hooks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ import 'package:path/path.dart' as p;
import 'package:watcher/watcher.dart';

const _defaultMaxFileCount = 10 * 1000 * 1000; // 10 million files
const _defaultMaxTotalLengthBytes = 2 * 1024 * 1024 * 1024; // 2 GiB

// TODO (sigurdm): reduce this back to 2 GiB when
// https://github.com/dart-lang/dartdoc/issues/3311 is resolved.
const _defaultMaxTotalLengthBytes =
2 * 1024 * 1024 * 1024 + 300 * 1024 * 1024; // 2 GiB + 300 MiB

/// Thrown when current output exceeds limits.
class DocumentationTooBigException implements Exception {
Expand Down