Display a report section on uncaught dartdoc tool failure. #5003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Aug 12, 2021
sigurdm
approved these changes
Aug 12, 2021
| job, | ||
| _emptyReport( | ||
| title: 'Failed to run dartdoc', | ||
| description: 'The dartdoc process timed out.', |
There was a problem hiding this comment.
Do we have a way to indicate the time it took? Should we?
There was a problem hiding this comment.
This is a tricky one: we have dartdoc runs that neither compete, nor time out (the timeout doesn't kill the process). Once we use the proper kill signal to do it (in this new release), I hope this class of error is gone and we can remove this block.
| title: title, | ||
| description: description, | ||
| grantedPoints: 0, | ||
| maxPoints: 10, |
There was a problem hiding this comment.
Is maxPoints 10 the right thing here? Maybe it doesn't really matter...
There was a problem hiding this comment.
Yeah, this is the score of the documentation block from pana.
Co-authored-by: Sigurd Meldgaard <[email protected]>
Co-authored-by: Sigurd Meldgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4750