Skip to content

Symlink and duplicate check in pkg/pub_package_reader #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

Symlink and duplicate check in pkg/pub_package_reader #4763

merged 1 commit into from
May 4, 2021

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 30, 2021

  • moved symlink check from pub-dev
  • implemented the same check for package:tar
  • added duplicate file check in both implementation

@isoos isoos requested a review from jonasfj April 30, 2021 15:23
@isoos isoos merged commit 8c5d7cc into dart-lang:master May 4, 2021
@isoos isoos deleted the archive branch May 4, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isoos @jonasfj @googlebot