Skip to content

Move top-level mustache templates to subdirs. #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 9, 2020

Also deleting uploader_approval.mustache, as it is no longer used.

@isoos isoos requested a review from jonasfj January 9, 2020 10:21
for details. All rights reserved. Use of this source code is governed by a
BSD-style license that can be found in the LICENSE file. }}

<h1>Uploader invitation</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to delete this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is no longer used. We have migrated upload approvals to use the consent page, removed the related handler and rendering, but the mustache file was not deleted at that time.

@isoos isoos merged commit d0912e8 into dart-lang:master Jan 9, 2020
@isoos isoos deleted the move-mustache branch January 9, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants