Skip to content

Greyscaled tab indicator. #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Greyscaled tab indicator. #1424

merged 2 commits into from
Jul 5, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jul 2, 2018

screen shot 2018-07-02 at 13 54 09

Black: active tab
Gray: on-hovering

/cc @mit-mit

@isoos isoos requested a review from sortie July 2, 2018 11:54
@mit-mit
Copy link
Member

mit-mit commented Jul 2, 2018

It looks a bit odd with the blue text and black highlight bar. Can you try to make the text black?

@isoos
Copy link
Collaborator Author

isoos commented Jul 2, 2018

Can you try to make the text black?

The text is already black, but we can make the rest of the tabs lighter, and the selected one bold. What about this?

screen shot 2018-07-02 at 14 05 51

@isoos
Copy link
Collaborator Author

isoos commented Jul 2, 2018

Although the bolding makes the line a bit to "move" on tab switching, and it is not bad without bold either:

screen shot 2018-07-02 at 14 08 57

@mit-mit
Copy link
Member

mit-mit commented Jul 2, 2018

Last example (black, no bold) LGTM!

Copy link

@sortie sortie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The indention style looks a tiny bit inconsistent in this stylesheet.

@isoos
Copy link
Collaborator Author

isoos commented Jul 5, 2018

The indention style looks a tiny bit inconsistent in this stylesheet.

It is, as it is a mixture of an old style, a new design which was handed to us, and our additional updates. I'm trying to make it more consistent (two tabs), but looks like I've missed it this time, will fix.

@isoos isoos merged commit 519bf35 into dart-lang:master Jul 5, 2018
@isoos isoos deleted the tab_underline branch July 5, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants