Greyscaled tab indicator. #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks a bit odd with the blue text and black highlight bar. Can you try to make the text black? |
The text is already black, but we can make the rest of the tabs lighter, and the selected one bold. What about this?
|
|
Although the bolding makes the line a bit to "move" on tab switching, and it is not bad without bold either:
|
|
Last example (black, no bold) LGTM! |
sortie
approved these changes
Jul 5, 2018
It is, as it is a mixture of an old style, a new design which was handed to us, and our additional updates. I'm trying to make it more consistent (two tabs), but looks like I've missed it this time, will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black: active tab
Gray: on-hovering
/cc @mit-mit