Skip to content

Use FLUTTER_ROOT in env variables. #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2018
Merged

Use FLUTTER_ROOT in env variables. #1344

merged 1 commit into from
Jun 7, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jun 2, 2018

@isoos isoos requested a review from sortie June 2, 2018 12:43
sortie
sortie approved these changes Jun 7, 2018
View reviewed changes
Copy link

@sortie sortie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/shared/configuration.dart should be app/lib/shared/configuration.dart.

I assume no change needs to be done to app/script/setup-flutter.sh and app/lib/shared/configuration.dart.

@isoos
Copy link
Collaborator Author

isoos commented Jun 7, 2018

lib/shared/configuration.dart should be app/lib/shared/configuration.dart.

Fixed.

I assume no change needs to be done to app/script/setup-flutter.sh and app/lib/shared/configuration.dart.

Yeah, those are fine.

@isoos isoos merged commit f2e0770 into dart-lang:master Jun 7, 2018
@isoos isoos deleted the flutter_root branch June 7, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sortie sortie sortie approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isoos @sortie @googlebot