Deprecated -> Discontinued #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Feb 21, 2018
isoos
commented
- renames fields, labels and template variables
- apply highly visible style
- removes discontinued items from the search index
jakobr-google
approved these changes
Feb 21, 2018
| @@ -47,8 +47,8 @@ class AnalysisStatusProperty extends StringProperty { | |||
| return AnalysisStatus.failure; | |||
| case 'success': | |||
| return AnalysisStatus.success; | |||
| case 'deprecated': | |||
There was a problem hiding this comment.
It won't be a problem in prod, but do we have entries with status=='deprecated' stored in dev?
There was a problem hiding this comment.
We have, but it is unlikely to cause problems.
There was a problem hiding this comment.
It'll cause an exception to be thrown here, right?
There was a problem hiding this comment.
It will. But it will happen only if the most-recent analysis gets deleted, and only the older 'deprecated' Analysis instance is available. The automatic removal of old Analysis instances will remove that soon and it won't cause issues.
There was a problem hiding this comment.
Right. No worries, then. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.