Skip to content

Support dartdoc --include option for API doc generation #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chalin opened this issue Apr 17, 2018 · 15 comments
Closed

Support dartdoc --include option for API doc generation #1216

chalin opened this issue Apr 17, 2018 · 15 comments

Comments

@chalin
Copy link
Contributor

chalin commented Apr 17, 2018

A package's pubspec documentation entry could support an include entry; e.g.

documentation:
  url: optional-url
  include: optional-list-of-libs

This is motivated by

cc @kevmoo @kwalrath @nshahan

@nshahan
Copy link

nshahan commented Apr 17, 2018

Would an exclude be feasible as well?

@chalin
Copy link
Contributor Author

chalin commented Apr 17, 2018

Probably makes sense to implement both. On the webdev site we currently only use include, but we did, at some point, need exclude as well.

@kevmoo
Copy link
Member

kevmoo commented Apr 18, 2018

CC @jcollins-g

Anything done here should coordinate w/ the new dartdoc_options.yaml

dart-lang/dartdoc@44dfb15

@jcollins-g
Copy link

I'm going as fast as I can to support all applicable dartdoc command line flags in dartdoc_options.yaml. I'm two PRs away from the initial support for this. Please file bugs on dart-lang/dartdoc for parameters and use cases that are important.

@isoos
Copy link
Collaborator

isoos commented Apr 18, 2018

I'm a bit sad that Dart is getting more-and-more separate config files (pubspec.yaml, analysis_options.yaml, build.yaml) and now dartdoc_options.yaml. Is there at least a plan to make the work under a single one?

@kevmoo
Copy link
Member

kevmoo commented Apr 18, 2018 via email

@isoos
Copy link
Collaborator

isoos commented Apr 18, 2018

I don't see much need for coordination when putting these under pubspec.yaml (besides the trivial agreement on the top-level key), after all Flutter does store some of its config there too. (Please don't tell me that those will be under a different file too...)

@chalin
Copy link
Contributor Author

chalin commented Apr 18, 2018

Please file bugs on dart-lang/dartdoc for parameters and use cases that are important.

@jcollins-g: can you give me a base issue # that I can refer to? Btw, do you already have support for include / exclude options covered in one of the already opened issues?

@jcollins-g
Copy link

@isoos There is no current plan to unify them. The name of the file and the top-level key is fairly mutable still for dartdoc (almost noone uses the current, limited functionality) but that's going to change very rapidly if I get my way.

@chalin There is one now: dart-lang/dartdoc#1674. I'm already planning to support many command line options including those, but if there's a particular use case (e.g. a command line you'd really prefer to be in a config file) I can make sure that happens.

@jakobr-google
Copy link
Contributor

We are assuming this will be handled by dartdoc

@jakobr-google jakobr-google added this to the Backlog milestone May 2, 2018
@jcollins-g
Copy link

dart-lang/dartdoc#1700 adds (tested and working) support for include/exclude in dartdoc_options.yaml.

@kevmoo
Copy link
Member

kevmoo commented May 30, 2018 via email

@chalin
Copy link
Contributor Author

chalin commented Jul 23, 2018

@isoos - has pub docs been setup to use this new functionality yet?

@isoos
Copy link
Collaborator

isoos commented Jul 23, 2018

has pub docs been setup to use this new functionality yet?

If dartdoc picks it up from the package archive, it should work, we don't actively prevent it. The current online version is using dartdoc 0.20.0.

@isoos
Copy link
Collaborator

isoos commented Jun 28, 2019

Due to security concerns we have disabled dartdoc_options.yaml(by deleting it before dartdoc is being run) a while back, and it is no longer and for the foreseeable future we are not going to enable it again. If/when we move the generated docs to a new domain we might consider enabling specific options (separately), please open new issues if you want us to support one or more of them.

@isoos isoos closed this as completed Jun 28, 2019
@isoos isoos removed this from the Backlog milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants