Skip to content

Use package:pedantic as default package analysis ruleset. #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 23, 2019

Fixes #459.

We need to add package:pedantic in the dev_dependencies, and subsequently remove it from the list of resolved packages (unless it is referenced in the original pubspec.yaml).

Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@isoos isoos merged commit 71594fd into dart-lang:master Jan 24, 2019
@isoos isoos deleted the pedantic branch January 24, 2019 10:20
@pq
Copy link
Member

pq commented Jan 24, 2019

Fantastic. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using pedantic as a baseline for linting?
4 participants