Temporarily allow modification of a BuildOutput's raw dependencies #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #168 was not caught due to the packages depending on each through through pub rather than as path dependencies. It was the
native_toolchain_c
tests that failed which earlier on CI depended on a version ofnative_assets_cli
during test.The core issue here is that
Dependencies
should likely be properly immutable (as indicated by itsconst
constructor that's always been there) and itsdependencies
property should instead be exposed as anIterable
or not at all directly.Since making those changes is a breaking change, I will instead follow-up with those changes as part of a
0.4.0
release. This fix removes the const lists/maps that the depending packages are not currently expecting.Fixes #168