7 - only_throw_errors lint
#1297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit-id:40c7a061
This was referenced Jul 11, 2024
Closed
dcharkes
reviewed
Jul 11, 2024
| @@ -10,6 +10,7 @@ | |||
| // ignore_for_file: lines_longer_than_80_chars | |||
| // ignore_for_file: no_leading_underscores_for_local_identifiers | |||
| // ignore_for_file: non_constant_identifier_names | |||
| // ignore_for_file: only_throw_errors | |||
There was a problem hiding this comment.
What are we throwing that doesn't extend Error or Exception? We probably should not be doing that.
There was a problem hiding this comment.
A string, I'll fix these once #561 lands.
| @@ -27,11 +29,11 @@ class Experiment { | |||
| factory Experiment.fromString(String s) { | |||
| final search = available.where((element) => element.name == s); | |||
| if (search.isEmpty) { | |||
| throw 'The experiment $s is not available in this version.'; | |||
| log.fatal('The experiment $s is not available in this version.'); | |||
There was a problem hiding this comment.
Does this stop execution? Or are we going to have more subsequent errors now?
dcharkes
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
unreachable_from_mainlint #1302unnecessary_parenthesislint #1301unnecessary_lambdaslint #1300type_annotate_public_apislint #1299prefer_single_quoteslint #1298only_throw_errorslint #1297 ⬅omit_local_variable_typeslint #1296lines_longer_than_80_charslint #1295library_annotationslint #1294directives_orderinglint #1293comment_referenceslint #1292avoid_catching_errorslint #1291