Skip to content

Try using a staged, fancy travis config. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 28, 2018

Conversation

matanlurey
Copy link
Contributor

We can keep this, or not. I'm assuming we want to test this package with DDC, so.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun!

@matanlurey
Copy link
Contributor Author

Completing this now

@matanlurey
Copy link
Contributor Author

@srawlins PTAL again.

Notable changes:

  • I fixed every test to work with DDC, I realize some tests are duplicates now.
  • The <T> return type for thenAnswer etc was not strong-mode clean; it tried to return the MockFoo object where T was expected (i.e. String). I fixed it.

@matanlurey
Copy link
Contributor Author

/cc @kevmoo


# Gives more resources on Travis (8GB Ram, 2 CPUs).
# Do not remove without verifying w/ Travis.
sudo: required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update mono_repo to handle "normal" repos – just to support generating this config.

I chatted w/ @natebosch about this yesterday
CC @alorenzen

@matanlurey
Copy link
Contributor Author

I can confirm this works fine locally.

I think this is the same issues that @grouma @nex3 @alorenzen are seeing for AngularDart (timeouts for the test runner). So whatever is the fix there should also be the fix here.

@nex3
Copy link
Member

nex3 commented Feb 26, 2018

We were seeing this with Chrome, not Firefox. If it's happening with both browsers, that's very interesting information.

@matanlurey
Copy link
Contributor Author

@nex3 Different error for Firefox:

00:00 +0 -1: compiling test/mockito_test.dart [E]                              
  Failed to load "test/mockito_test.dart":
  Failed to run Firefox: Firefox failed with exit code 1.
  Standard output:
  Error: GDK_BACKEND does not match available displays
  .
  package:test/src/runner/browser/browser.dart 108           new Browser.<fn>

@matanlurey
Copy link
Contributor Author

@srawlins FYI, this should work now. I am going to merge on green.

@matanlurey matanlurey merged commit 66ed4fe into dart-lang:master Feb 28, 2018
@matanlurey matanlurey deleted the try-fancy-travis branch February 28, 2018 00:00
srawlins added a commit that referenced this pull request Apr 16, 2018
* master:
  Remove upper case constants (#113)
  Bump to 3.0.0-alpha+3 (#112)
  Switch back to Chrome for Travis (#104)
  Try using a staged, fancy travis config. (#100)
  Update travis script to actually run dartanalyzer (#102)
  verify*Interactions methods throw helpfully that they expect Mock (#92)
  First draft of upgrade guide for Mockito 3.0 (#96)
  Generic support for `thenReturn` and `thenAnswer` (#101)
  Remove references to `@proxy`. (#99)
  Remove Spy docs (#97)
  Remove mirrors implementation (#91)
mosuem pushed a commit to dart-lang/test that referenced this pull request Oct 17, 2024
* Try using a staged, fancy travis config.

* Remove env.

* Use dart:dev .

* Fix script.

* Fix script.

* Ignore DDC failures for now.

* Fix dart2js.

* Actually skip.

* Fix again.

* Dartfmt.

* Add dart_test.yaml.

* Try firefox instead.

* Fix travis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants