-
Notifications
You must be signed in to change notification settings - Fork 214
Proposal for "base", "interface" and "final" type modifiers. #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
lrhn
reviewed
Nov 22, 2022
eernstg
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Added a handful of comments.
Co-authored-by: Erik Ernst <[email protected]>
I'm going to go ahead and land this, because it's just a proposal either way. I'd like to talk about moving it forward soon, though, since I think it will be valuable to have these modifiers at the same time that we introduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a new proposal for a set of capability modifiers on types. It supersedes my earlier "closed" and "base" proposal (#2592), which I'll close. It's heavily based on @leafpetersen's proposal (#2595), incorporates a suggestion from @natebosch to use a metadata annotation for
@reopen
and Erik's discussion of invariants you get from removing capabilities (which I hope I captured OK here).Let me know what you think!
@mit-mit @stereotype441 @jakemac53 @kallentu