Don't write the failure string when skipping (#220)

* Don't write the failure string when skipping

* Fix bash command

* Don't exit with 4

* Test not checking for changelog

* Test removing changelog from health defaults

* Add debug steps

* Switch changelog if clause syntax

* Fix all

* Revert debug changes

* Revert "Test removing changelog from health defaults"

This reverts commit c9836e0.

* Remove changelog

* Remove debug change

Author: mosuem

.github/workflows/health.yaml

@@ -86,7 +86,7 @@ on:
 
 jobs:
   version:
-    if: contains(${{ inputs.checks }}, 'version')
+    if: ${{ contains(inputs.checks, 'version') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}
@@ -97,7 +97,7 @@ jobs:
       use-flutter: ${{ inputs.use-flutter }}
 
   changelog:
-    if: contains(${{ inputs.checks }}, 'changelog')
+    if: ${{ contains(inputs.checks, 'changelog') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}
@@ -108,7 +108,7 @@ jobs:
       use-flutter: ${{ inputs.use-flutter }}
 
   license:
-    if: contains(${{ inputs.checks }}, 'license')
+    if: ${{ contains(inputs.checks, 'license') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}
@@ -119,7 +119,7 @@ jobs:
       use-flutter: ${{ inputs.use-flutter }}
 
   coverage:
-    if: contains(${{ inputs.checks }}, 'coverage')
+    if: ${{ contains(inputs.checks, 'coverage') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}
@@ -132,7 +132,7 @@ jobs:
       use-flutter: ${{ inputs.use-flutter }}
 
   breaking:
-    if: contains(${{ inputs.checks }}, 'breaking')
+    if: ${{ contains(inputs.checks, 'breaking') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}
@@ -143,7 +143,7 @@ jobs:
       use-flutter: ${{ inputs.use-flutter }}
 
   do-not-submit:
-    if: contains(${{ inputs.checks }}, 'do-not-submit')
+    if: ${{ contains(inputs.checks, 'do-not-submit') }}
     uses: ./.github/workflows/health_base.yaml
     with:
       sdk: ${{ inputs.sdk }}

.github/workflows/health_base.yaml

@@ -71,10 +71,7 @@ jobs:
           path: base_repo/
         if: ${{ inputs.check == 'coverage' }} || ${{ inputs.check == 'breaking' }}
 
-      - name: Write comment if not present
-        run: |
-         mkdir -p current_repo/output/
-         test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
+      - run: mkdir -p current_repo/output/
 
       - uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225
         if: ${{ inputs.use-flutter }}
@@ -109,7 +106,16 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           ISSUE_NUMBER: ${{ github.event.number }}
           PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}"
-        run: cd current_repo/ && dart pub global run firehose:health --check ${{ inputs.check }} ${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} --fail_on ${{ inputs.fail_on }} --warn_on ${{ inputs.warn_on }}
+        run: |
+          cd current_repo/
+          dart pub global run firehose:health \
+            --check ${{ inputs.check }} \
+            ${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} \
+            --fail_on ${{ inputs.fail_on }} \
+            --warn_on ${{ inputs.warn_on }}
+
+      - run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
+        if: ${{ '$action_state' == 1 }}
 
       - name: Upload coverage to Coveralls
         if: ${{ inputs.upload_coverage }}