Relax assumptions on workspaces in firehose (#375)

Author: mosuem

pkgs/firehose/CHANGELOG.md

@@ -3,6 +3,7 @@
 - Make the PR health output less verbose by collapsing warnings by default.
 - Bump dart_apitool to fix errors with equal types being reported as different.
 - Give comment files in health work.
+- Don't ignore workspace pubspecs.
 
 ## 0.12.0
 

pkgs/firehose/lib/src/repo.dart

@@ -62,11 +62,14 @@ class Repository {
     if (pubspecFile.existsSync()) {
       var pubspec = yaml.loadYaml(pubspecFile.readAsStringSync()) as Map;
       var publishTo = pubspec['publish_to'] as String?;
-      if (publishTo != 'none' && !pubspec.containsKey('workspace')) {
+      if (publishTo != 'none') {
+        print('Found published package at $directory');
         packages.add(Package(directory, this));
-        // There is an assumption here that published, non-workspace packages do
-        // not contain nested published packages.
+        // There is an assumption here that published packages do not contain
+        // nested published packages.
         return;
+      } else {
+        print('Ignoring non-published package at $directory');
       }
     }
     if (directory.existsSync()) {

pkgs/firehose/test_data/workspace_repo/pubspec.yaml

@@ -1,4 +1,7 @@
 name: workspace
+
+publish_to: none
+
 workspace:
   - pkg_1
   - pkg_2