Skip to content

display descriptions with ellipses #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2015
Merged

Conversation

devoncarew
Copy link
Member

  • fix Provide a hint where text is hidden behind a link in the overview #808; display one line of a description summary - use ellipses if it doesn't fit. This had been our behavior; not sure if this regressed or it was a conscious choice to move away from it.
  • display the glass pane w/ slightly less opacity
  • the columns on the index page now add up to 12
  • move the nav from right to left on the index page. This way the libraries nav is in a consistent place when it's visible on the page.

screen shot 2015-08-11 at 1 02 48 am

@devoncarew
Copy link
Member Author

fix #806

@sethladd
Copy link
Contributor

Thanks!

move the nav from right to left on the index page.

I don't care if that particular nav is on the left or right, but I'd like it consistent across all the pages. Can we move all the other pages, too?

@devoncarew
Copy link
Member Author

The library nav is on the left for all the pages.

page left nav right nav
index libraries none
library libraries library members
class library members class members
class member class members none

@devoncarew
Copy link
Member Author

I think this is the least surprising structure for users. The first and last pages (tree root and leaf nodes) are a bit of special cases.

@sethladd
Copy link
Contributor

Bonus points for using a table! :)

I find it inconsistent, but the world is a messy place.

lgtm!

devoncarew added a commit that referenced this pull request Aug 11, 2015
@devoncarew devoncarew merged commit a7ae7db into master Aug 11, 2015
@devoncarew devoncarew deleted the ddc_description_overflow branch August 18, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a hint where text is hidden behind a link in the overview
2 participants