Skip to content

include version in html comments, add some missing titles, major refactoring #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

include version in html comments, add some missing titles, major refactoring #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32b1817
refactor html generator
sethladd Aug 7, 2015
f629d9a
add missing fields
sethladd Aug 7, 2015
c4c59ae
major refactoring, also include version in html comments
sethladd Aug 7, 2015
365bfb0
Merge branch 'master' of github.com:dart-lang/dartdoc into sl-version…
sethladd Aug 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions lib/dartdoc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import 'package:analyzer/src/generated/source_io.dart';

import 'generator.dart';
import 'resource_loader.dart' as loader;
import 'src/html_generator.dart';
import 'src/html_generator.dart' show dartdocVersion, HtmlGenerator;
import 'src/io_utils.dart';
import 'src/model.dart';
import 'src/model_utils.dart';
Expand All @@ -37,6 +37,7 @@ final String defaultOutDir = 'doc${Platform.pathSeparator}api';
/// Initialize and setup the generators.
List<Generator> initGenerators(
String url, String headerFilePath, String footerFilePath) {
dartdocVersion = version;
return [
new HtmlGenerator(url, header: headerFilePath, footer: footerFilePath)
];
Expand All @@ -57,8 +58,15 @@ class DartDoc {

Stopwatch _stopwatch;

DartDoc(this.rootDir, this.excludes, this.sdkDir, this.generators,
this.outputDir, this.packageRootDir, this.packageMeta, this.urlMappings,
DartDoc(
this.rootDir,
this.excludes,
this.sdkDir,
this.generators,
this.outputDir,
this.packageRootDir,
this.packageMeta,
this.urlMappings,
this.includes);

/// Generate DartDoc documentation.
Expand Down Expand Up @@ -178,8 +186,8 @@ class DartDoc {
}).where((_Error error) => error.isError).toList()..sort();

double seconds = _stopwatch.elapsedMilliseconds / 1000.0;
print(
"Parsed ${libraries.length} " "file${libraries.length == 1 ? '' : 's'} in "
print("Parsed ${libraries.length} "
"file${libraries.length == 1 ? '' : 's'} in "
"${seconds.toStringAsFixed(1)} seconds.\n");

if (errors.isNotEmpty) {
Expand Down
Loading