change names for library and class files #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -507,7 +507,7 @@ class Library extends ModelElement { | |||
|
|
|||
| String get path => _library.definingCompilationUnit.name; | |||
|
|
|||
| String get nameForFile => name.replaceAll(':', '-'); | |||
There was a problem hiding this comment.
I'm not a huge fan of this change. If I see a variable called "fileName", I'm going to assume it's the filename. As it stands, it's really just the part of the filename before the suffix.
I used nameForFile to make that clearer. There's probably a better name, but I think fileName promises too much.
There was a problem hiding this comment.
changing this to dirName and adding a fileName that returns libName-library.html to make this clear.
There was a problem hiding this comment.
dirName is much better name than nameForFile :)
|
Thanks @keertip ! Left a few comments. |
|
lgtm thank! |
keertip
added a commit
that referenced
this pull request
Jul 8, 2015
change names for library and class files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sethladd
closes #585