Improve logic of calculating a "fully qualified name" #3836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For improvements that I'm working on in another CL, it made sense to tidy up this code. The
_buildFullyQualifiedName
function was unnecessarily recursive and complex. And then the_fullyQualifiedNameWithoutLibrary
function (a) has a complex name and (b) also worked further to do undo some work done in_buildFullyQualifiedName
. This CL tidies these two "fields".fullyQualifiedName
and_buildFullyQualifiedName
into one getter (removing one field).fullyQualifiedNameWithoutLibrary
and_fullyQualifiedNameWithoutLibrary
into one late final field, remove recursion, and simplify name toqualifiedName
. Also mark as@visibleForOverriding
. It should be private but because of the mixin hierarchy, it is declared in one file, and defined in another.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.