Skip to content

Small patch to fix macros revert in Dart SDK #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Small patch to fix macros revert in Dart SDK #3732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/src/model/package_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,11 @@ class PubPackageBuilder implements PackageBuilder {

List<String> get _sdkFilesToDocument => [
for (var sdkLib in _sdk.sdkLibraries)
_sdk.mapDartUri(sdkLib.shortName)!.fullName,
// TODO(srawlins): This bit is temporary, here in order to unblock some
// unfortunate CI in the Dart SDK which is not designed well for when
// SDK libraries are _removed_.
if (!sdkLib.shortName.contains('macros'))
_sdk.mapDartUri(sdkLib.shortName)!.fullName,
];

/// Resolves a single library at [filePath] using the current analysis driver.
Expand Down