Skip to content

Do not crash in the presence of macro applications. #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Feb 21, 2024

Fixes #3653

  • Dispose of an AnalysisContextCollectionImpl.
  • Before getting class hierarchy, navigate to possible augmentation declaration.
  • Do not attempt to access source code of augmentation elements.

I cannot add tests yet because dartdoc needs to depend on a pinned version of the analyzer which matches the SDK in which the tests are run. We could do this if dartdoc was in the SDK repo, and we will more likely start when the macro API stuff is moved to a dart: library.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

* Dispose of an AnalysisContextCollectionImpl.
* Before getting class hierarchy, navigate to possible augmentation declaration.
* Do not attempt to access source code of augmentation elements.
@srawlins srawlins requested a review from kallentu February 21, 2024 14:19
@srawlins srawlins merged commit c0ed677 into dart-lang:main Feb 21, 2024
@srawlins srawlins deleted the fix-macros branch February 21, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dartdoc crashes with macros
2 participants