Skip to content

Fix remote linking in 2.18 and 3.0.0 #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2022
Merged

Fix remote linking in 2.18 and 3.0.0 #3267

merged 3 commits into from
Dec 12, 2022

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Dec 9, 2022 •
edited
Loading

Should fix issues with cross-linking to remote packages, found in dart-lang/pub-dev#6264

  • Add a pair to the 'hosted' Map default value for the 'linkTo' command line option.
  • Remove test of shelf_exception_handler, which is a dead package.
  • Bump the environment for sky_engine to handle Dart 3.0.0-dev.

@srawlins srawlins mentioned this pull request Dec 9, 2022
Closed
@srawlins srawlins changed the title Fix remote linking in 2.18 Fix remote linking in 2.18 and 3.0.0 Dec 10, 2022
@srawlins srawlins requested review from scheglov and keertip December 10, 2022 22:43
@srawlins srawlins merged commit bede500 into dart-lang:master Dec 12, 2022
@srawlins srawlins deleted the fix-two-eighteen-links branch December 12, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keertip keertip keertip approved these changes

@scheglov scheglov Awaiting requested review from scheglov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @keertip