Skip to content

Move much PackageWarning logic _out_ of PackageGraph, into the enum. #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

Move much PackageWarning logic _out_ of PackageGraph, into the enum. #3251

merged 1 commit into from
Nov 15, 2022

Conversation

srawlins
Copy link
Member

This makes PackageGraph.warnOnElement significantly simpler, and moves a lot of logic to where it should live.

@srawlins srawlins requested a review from scheglov November 14, 2022 17:59
@srawlins srawlins merged commit dc502d0 into dart-lang:master Nov 15, 2022
@srawlins srawlins deleted the warnable branch November 15, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheglov scheglov scheglov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @scheglov