Skip to content

Simplify some fields and getters in Package #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2022
Merged

Simplify some fields and getters in Package #3104

merged 2 commits into from
Aug 3, 2022

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Aug 2, 2022 •
edited
Loading

  • Make excludePackages private.
  • Rename private fields _name, _packageGraph, and _packageMeta to be public; they had public getters; so there is nothing wrong with making them final and public.
  • Make packagePath a final field as it is used a lot and involves a calculation.
  • Make isPublic, _isExcluded and _isLocalPublicByDefault, fileType into getters instead of late final; cheaper this way

@srawlins srawlins requested a review from keertip August 2, 2022 19:55
@srawlins srawlins merged commit bd57c0e into dart-lang:master Aug 3, 2022
@srawlins srawlins deleted the simplify-package branch August 3, 2022 21:51
klr981 pushed a commit to klr981/dartdoc that referenced this pull request Aug 8, 2022
@srawlins @klr981
Simplify some fields and getters in Package (dart-lang#3104)
227e90a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keertip keertip keertip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @keertip