Skip to content

Use dart run instead of deprecated dart pub run #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2022
Merged

Use dart run instead of deprecated dart pub run #3038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
922dc81
Use dart run instead of deprecated dart pub run
srawlins May 17, 2022
89ab8c5
One more
srawlins May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tool/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,23 @@ if [ "$DARTDOC_BOT" = "sdk-docs" ]; then
# silence stdout but echo stderr
echo ""
echo "Building and validating SDK docs..."
dart pub run grinder validate-sdk-docs
dart run grinder validate-sdk-docs
echo "SDK docs process finished"
elif [ "$DARTDOC_BOT" = "flutter" ]; then
echo "Running flutter dartdoc bot"
dart pub run grinder validate-flutter-docs
dart run grinder validate-flutter-docs
elif [ "$DARTDOC_BOT" = "packages" ]; then
echo "Running packages dartdoc bot"
PACKAGE_NAME=angular PACKAGE_VERSION=">=7.0.0" DARTDOC_PARAMS="--include=angular" dart pub run grinder build-pub-package
PACKAGE_NAME=access PACKAGE_VERSION=">=1.0.1+2" dart pub run grinder build-pub-package
PACKAGE_NAME=angular PACKAGE_VERSION=">=7.0.0" DARTDOC_PARAMS="--include=angular" dart run grinder build-pub-package
PACKAGE_NAME=access PACKAGE_VERSION=">=1.0.1+2" dart run grinder build-pub-package
# Negative test for flutter_plugin_tools, make sure right error message is displayed.
PACKAGE_NAME=flutter_plugin_tools PACKAGE_VERSION=">=0.0.14+1" dart pub run grinder build-pub-package 2>&1 | grep "warning: package:flutter_plugin_tools has no documentable libraries"
PACKAGE_NAME=shelf_exception_handler PACKAGE_VERSION=">=0.2.0" dart pub run grinder build-pub-package
PACKAGE_NAME=flutter_plugin_tools PACKAGE_VERSION=">=0.0.14+1" dart run grinder build-pub-package 2>&1 | grep "warning: package:flutter_plugin_tools has no documentable libraries"
PACKAGE_NAME=shelf_exception_handler PACKAGE_VERSION=">=0.2.0" dart run grinder build-pub-package
elif [ "$DARTDOC_BOT" = "sdk-analyzer" ]; then
echo "Running all tests against the SDK analyzer"
unset COVERAGE_TOKEN
dart pub run grinder test-with-analyzer-sdk
dart run grinder test-with-analyzer-sdk
else
echo "Running main dartdoc bot"
dart pub run grinder buildbot
dart run grinder buildbot
fi
2 changes: 1 addition & 1 deletion tool/grind.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ String _getPackageVersion() {
Future<void> build() async {
var launcher = SubprocessLauncher('build');
await launcher.runStreamed(Platform.resolvedExecutable,
['pub', 'run', 'build_runner', 'build', '--delete-conflicting-outputs']);
['run', 'build_runner', 'build', '--delete-conflicting-outputs']);

// TODO(jcollins-g): port to build system?
var version = _getPackageVersion();
Expand Down