Skip to content

Optimize built js #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2022
Merged

Optimize built js #3028

merged 4 commits into from
May 17, 2022

Conversation

parlough
Copy link
Member

@parlough parlough commented Apr 20, 2022 •
edited
Loading

445 -> 167 KB

We don't have any testing at the moment, but manual testing showed everything as working well.

@parlough parlough mentioned this pull request Apr 20, 2022
Merged
srawlins
srawlins approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many apps ship with this; I like it.

@srawlins
Copy link
Member

Oops, would you mind re-generating, and I can merge.

kevmoo
kevmoo reviewed May 17, 2022
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go further! No big concerns about data corruption here.

@parlough parlough requested a review from srawlins May 17, 2022 21:23
@srawlins srawlins merged commit 30ecfe5 into dart-lang:master May 17, 2022
@parlough parlough deleted the misc/optimize-built-js branch May 17, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@srawlins srawlins Awaiting requested review from srawlins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @srawlins @kevmoo