Add tests for named arguments anywhere in constant #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests involve a new paradigm: using test_descriptor to fill out a directory tree.
The named-arguments-anywhere experiment requires an SDK of 2.17 or greater, so in order to run the test suite with 2.15, we cannot bump the testing/test_package_experiments pubspec to 2.17, because then that SDK could not
pub get.test_descriptor allows us to use real files (and so
pub getand tools, etc still work) but store all of a test's logic in one place, rather than in testing/.