Get rid of a backlog of potentially suboptimal coding practices in dartdoc #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Oct 8, 2021
| - slash_for_doc_comments | ||
| - type_annotate_public_apis | ||
| # - unnecessary_brace_in_string_interps | ||
| always_declare_return_types: true |
There was a problem hiding this comment.
Why a map here and no the (more conventional) list?
There was a problem hiding this comment.
Because there is no way to say "false" in a list (unless there's something I'm missing), to override something in recommended/core. If I want to say false later I will have to convert to a map, so just do it now.
There was a problem hiding this comment.
Yeah. There's a note about this short-coming in the docs:
https://dart.dev/guides/language/analysis-options#disabling-individual-rules
Unfortunate.
pq
reviewed
Oct 8, 2021
| @@ -1,6 +1,6 @@ | |||
| // WARNING: This file is auto-generated. Do not taunt. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get us completely off of pedantic for lints/hints, fix all the problems highlighted by the "recommended" set, and eliminate declarations that are now duplicates in the analysis options.
The quoting lint actually discovered some (minimally consequential) bugs, where things that were supposed to be literal backslashes were being ignored. In some cases (generated code and tests mostly) I've added a few whole-file exceptions but most other exceptions I've tried to keep to a minimum.