Skip to content

Constructor refactor for ElementType #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

Similar to #2828, avoid direct factory calls and route through ModelBuilder.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Oct 7, 2021
@jcollins-g jcollins-g requested a review from srawlins October 8, 2021 16:00
/// Library interface is currently under heavy construction and may change
/// drastically between minor revisions.
/// Library interface is still experimental.
@experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jcollins-g jcollins-g merged commit c45302c into dart-lang:master Oct 8, 2021
@jcollins-g jcollins-g deleted the elementtype-constructor-refactor branch October 8, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants