Skip to content

Remove old lookup code and obliterate the tables that it depended on #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions lib/src/dartdoc_options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1291,9 +1291,6 @@ class DartdocOptionContext extends DartdocOptionContextBase
List<String> get excludePackages =>
optionSet['excludePackages'].valueAt(context);

bool get enhancedReferenceLookup =>
optionSet['enhancedReferenceLookup'].valueAt(context);

String get flutterRoot => optionSet['flutterRoot'].valueAt(context);

bool get hideSdkText => optionSet['hideSdkText'].valueAt(context);
Expand Down Expand Up @@ -1427,17 +1424,6 @@ Future<List<DartdocOption>> createDartdocOptions(
help: 'Library names to ignore.', splitCommas: true),
DartdocOptionArgOnly<List<String>>('excludePackages', [], resourceProvider,
help: 'Package names to ignore.', splitCommas: true),
DartdocOptionArgFile<bool>(
'enhancedReferenceLookup', true, resourceProvider,
hide: true,
help:
'Use the new comment reference lookup system instead of the legacy '
'version. Please file a bug referencing this flag if you have to '
'change it to false -- this flag and associated behavior will '
'disappear in a future version.',
negatable: true),
// This could be a ArgOnly, but trying to not provide too many ways
// to set the flutter root.
DartdocOptionSyntheticOnly<String>(
'flutterRoot',
(DartdocSyntheticOption<String> option, Folder dir) => resourceProvider
Expand Down
31 changes: 2 additions & 29 deletions lib/src/generator/templates.runtime_renderers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3357,20 +3357,6 @@ class _Renderer_Container extends RendererBase<Container> {
parent: r));
},
),
'allModelElementsByNamePart': Property(
getValue: (CT_ c) => c.allModelElementsByNamePart,
renderVariable: (CT_ c, Property<CT_> self,
List<String> remainingNames) =>
self.renderSimpleVariable(
c, remainingNames, 'Map<String, List<ModelElement>>'),
isNullValue: (CT_ c) => c.allModelElementsByNamePart == null,
renderValue: (CT_ c, RendererBase<CT_> r,
List<MustachioNode> ast, StringSink sink) {
renderSimple(
c.allModelElementsByNamePart, ast, r.template, sink,
parent: r, getters: _invisibleGetters['Map']);
},
),
'constantFields': Property(
getValue: (CT_ c) => c.constantFields,
renderVariable: (CT_ c, Property<CT_> self,
Expand Down Expand Up @@ -7460,19 +7446,6 @@ class _Renderer_Library extends RendererBase<Library> {
parent: r, getters: _invisibleGetters['HashMap']);
},
),
'modelElementsNameMap': Property(
getValue: (CT_ c) => c.modelElementsNameMap,
renderVariable: (CT_ c, Property<CT_> self,
List<String> remainingNames) =>
self.renderSimpleVariable(c, remainingNames,
'HashMap<String, Set<ModelElement>>'),
isNullValue: (CT_ c) => c.modelElementsNameMap == null,
renderValue: (CT_ c, RendererBase<CT_> r,
List<MustachioNode> ast, StringSink sink) {
renderSimple(c.modelElementsNameMap, ast, r.template, sink,
parent: r, getters: _invisibleGetters['HashMap']);
},
),
'name': Property(
getValue: (CT_ c) => c.name,
renderVariable:
Expand Down Expand Up @@ -14803,6 +14776,7 @@ const _invisibleGetters = {
'DartType': {
'hashCode',
'runtimeType',
'alias',
'aliasArguments',
'aliasElement',
'displayName',
Expand Down Expand Up @@ -14842,7 +14816,6 @@ const _invisibleGetters = {
'examplePathPrefix',
'exclude',
'excludePackages',
'enhancedReferenceLookup',
'flutterRoot',
'hideSdkText',
'include',
Expand Down Expand Up @@ -15112,6 +15085,7 @@ const _invisibleGetters = {
'LibraryElement': {
'hashCode',
'runtimeType',
'accessibleExtensions',
'definingCompilationUnit',
'entryPoint',
'exportedLibraries',
Expand Down Expand Up @@ -15239,7 +15213,6 @@ const _invisibleGetters = {
'implementors',
'documentedExtensions',
'extensions',
'findRefElementCache',
'defaultPackageName',
'defaultPackage',
'hasFooterVersion',
Expand Down
Loading